Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] add jackson-databind-nullable dependency to the gradle.build file #3793

Merged
merged 3 commits into from
Aug 30, 2019

Conversation

jmini
Copy link
Member

@jmini jmini commented Aug 29, 2019

Follow up of PR #3474: The new dependency org.openapitools:jackson-databind-nullable is missing in the gradle file.


To reproduce the issue:

In samples/client/petstore/java/jersey2 run: ./gradlew build (you might need chmod +x before, see #3792)

Log:

:compileJava
warning: [options] bootstrap class path not set in conjunction with -source 1.7
/...../<openapi-generator-repo>/samples/client/petstore/java/jersey2/src/main/java/org/openapitools/client/JSON.java:6: error: package org.openapitools.jackson.nullable does not exist
import org.openapitools.jackson.nullable.JsonNullableModule;
                                        ^
/...../<openapi-generator-repo>/samples/client/petstore/java/jersey2/src/main/java/org/openapitools/client/JSON.java:31: error: cannot find symbol
    JsonNullableModule jnm = new JsonNullableModule();
    ^
  symbol:   class JsonNullableModule
  location: class JSON
/...../<openapi-generator-repo>/samples/client/petstore/java/jersey2/src/main/java/org/openapitools/client/JSON.java:31: error: cannot find symbol
    JsonNullableModule jnm = new JsonNullableModule();
                                 ^
  symbol:   class JsonNullableModule
  location: class JSON
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
3 errors
1 warning
:compileJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 10.147 secs


This PR adds the requested dependency.

@auto-labeler
Copy link

auto-labeler bot commented Aug 29, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

Copy link
Contributor

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good catch. I completely forgot to look at this file while doing my original PR since I don't use gradle.

@jmini jmini added this to the 4.1.2 milestone Aug 29, 2019
@wing328 wing328 merged commit d21b339 into OpenAPITools:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants