Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime error in the model's valid? of Ruby client #3671

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

autopp
Copy link
Contributor

@autopp autopp commented Aug 18, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
    @cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)

Description of the PR

Fix #3670.

  • Fix accessing to openapi_one_of and openapi_any_of
  • Fix usage of _one_of_found and _any_of_found

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 1a6d367 into OpenAPITools:master Aug 19, 2019
@wing328 wing328 added this to the 4.1.1 milestone Aug 19, 2019
@autopp autopp deleted the fix-valid-method-in-ruby-client branch August 19, 2019 05:41
@wing328 wing328 changed the title Fix runtime error in the model's valid? of Ruby client (#3670) Fix runtime error in the model's valid? of Ruby client Aug 26, 2019
@wing328
Copy link
Member

wing328 commented Aug 26, 2019

@autopp thanks for the PR, which has been included in the v4.1.1 release: https://twitter.com/oas_generator/status/1165944867391860737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Ruby] valid? for model that contains oneOf or anyOf raises exception
2 participants