Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpp-qt5-client: Improve tests #3667

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

MartinDelille
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR refactor the Qt5 client Petstore tests:

  • remove unnecessary headers
  • remove unnecessary constructor/destructor for test classes
  • avoid QString constructor when possible
  • PetStore executable returns the number of failed tests
  • Simplify test logic user QTimer::singleShoot() static method
  • don't declare lambda if used only one time
  • use simple connect to lambda form
  • replace QList<QString> by {..., ..., ...}

The idea is to reduce the test code base without altering its readability. All the change are based on my opinions and I'll be totally ok to discard change that doesn't comply with good practice you'll oppose it to! 😃

@ravinikam @stkrwork @etherealjoy @muttleyxd

@etherealjoy
Copy link
Contributor

It looks good to me :)

@etherealjoy etherealjoy added this to the 4.1.1 milestone Aug 19, 2019
@etherealjoy etherealjoy merged commit 1adb0ba into OpenAPITools:master Aug 19, 2019
@MartinDelille MartinDelille deleted the improve-cpp-qt5-test branch August 19, 2019 17:41
@wing328
Copy link
Member

wing328 commented Aug 26, 2019

@MartinDelille thanks for the PR, which has been included in the v4.1.1 release: https://twitter.com/oas_generator/status/1165944867391860737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants