[Ruby][faraday] Properly pass verify_mode to faraday #3652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkliban
approved these changes
Aug 15, 2019
|
The list of available options is here: https://github.com/lostisland/faraday/blob/master/lib/faraday/options/ssl_options.rb |
|
Please update the Ruby sample via "./bin/openapi3/ruby-client-faraday-petstore.sh" so that the CI can verify the result. |
|
@jlsherrill Thanks for PR, the change looks good to me. |
8f4c2c0 to
7db94e3
Compare
|
Added! |
7db94e3 to
02ccc60
Compare
autopp
approved these changes
Aug 16, 2019
|
@jlsherrill The PR was merged, thanks! |
|
@jlsherrill thanks for the PR, which has been included in the v4.1.1 release: https://twitter.com/oas_generator/status/1165944867391860737 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
This seems to be the correct attribute based on the faraday ssl options here:
https://github.com/lostisland/faraday/blob/1c3bf50d8a28d71b11fca897ebdc71577c33ec6a/lib/faraday/options/ssl_options.rb#L15
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)