Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] process TRACE operation #3648

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

jmini
Copy link
Member

@jmini jmini commented Aug 15, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @OpenAPITools/generator-core-team

Description of the PR

Fixes #3647

Before this change the trace operation under all PathItem is just ignored by OpenAPI-
Generator.

With this change, the operation is considered. As written on the issue, the generator maintainers might need to do some changes to produce correct code for the trace operation.

@auto-labeler
Copy link

auto-labeler bot commented Aug 15, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@jmini
Copy link
Member Author

jmini commented Aug 15, 2019

Tested on the Java client generator (without any further changes to the templates) with a spec like this:

openapi: 3.0.1
info:
  title: OpenAPI Test
  description: Test Spec
  version: 1.0.0
  license:
    name: Apache-2.0
    url: 'http://www.apache.org/licenses/LICENSE-2.0.html'
servers:
  - url: 'http://localhost:8090/'
paths:
  /lorem/traceEmpty:
    trace:
      tags:
        - lorem
      operationId: emptyTrace
      responses:
        '201':
          description: OK

All java-client libs are producing code that compiles:

  • java-feign
  • java-google-api-client
  • java-jersey2
  • java-okhttp-gson
  • java-rest-assured
  • java-resteasy
  • java-resttemplate
  • java-webclient

And my first tests against a Mock-Server are also positive.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 added this to the 4.1.1 milestone Aug 15, 2019
@wing328 wing328 merged commit 2ada4d9 into OpenAPITools:master Aug 15, 2019
@jmini
Copy link
Member Author

jmini commented Aug 15, 2019

And my first tests against a Mock-Server are also positive.

I spoke too quickly, I have found an issue with java-jersey2 and java-resteasy:
see PR #3653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OpenAPI v3] Support for TRACE operation
2 participants