[Dart] Avoid redundant null checking in fromJson #3632
Conversation
- removed surrounding null check - added a conditional expression to each case except the redundant one
| @@ -2,11 +2,11 @@ part of openapi.api; | |||
|
|
|||
| class ApiResponse { | |||
|
|
|||
| int code = null; | |||
| int code = null; | |||
There was a problem hiding this comment.
@nickmeinhold looks like there are 2 additional space inserted. Is that intentional?
There was a problem hiding this comment.
No, not intentional - I didn't notice that sorry. At first glance I don't understand where the extra spaces have come from as the only change I made to the template was inside the fromJson part. Any thoughts? I will have a look tonight and see if I can understand it.
There was a problem hiding this comment.
Yeah I really don't get this - these lines are presumably generated by line4 of class.mustache and I haven't changed it or anything else nearby. I'm still learning mustache, there must be something about how the indentation works that I'm missing. I will read up more on mustache when I get some time, probably won't be today though.
There was a problem hiding this comment.
Don't worry. I'll take care of the formating with another PR
* master: (45 commits) update python samples Two tiny fixes for Java Vertx client (#3683) Exclude "test" from packages so that it is not installed as top-level package when "pip installing" the generated sdk (#3731) [java-client] add unit test for JDK 11 HttpClient (#3735) [R] feat(r): handling error response for 3xx cases (#3571) [Dart] Avoid redundant null checking in fromJson (#3632) [core] Set isMultipart=true for multipart operations, fix possible NPE (#3750) reenable kotlin client tests in shippable ci (#3751) Fix null assignation to header/query param map (#3749) Mockito 3.0.0 (#3732) Update to swagger-parser to 2.0.14-OpenAPITools.org-1 (#3737) Add a link to a Qiita blog post (#3747) update csharp samples Simple spelling error in dotnet core comments (#3746) better support for multipart (#3736) [typescript-fetch] fix #1998: prefix req ifaces. (#3740) cpp-qt5-client: add valgrind memory test (#3663) [typescript-angular] Encode objects for multipart/form-data with json - fixes #2733 (#3738) [BUG] Https protocol schema is not handled correctly in java 11 native code #3729 (#3730) comment out kotlin client tests ...
|
@nickmeinhold thanks for the PR, which has been included in the v4.1.1 release: https://twitter.com/oas_generator/status/1165944867391860737 |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
fix #3628