-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typescript-angular: Add correct library versions for Angular 8.0.0 #3619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -52,7 +52,7 @@ | |||
public static final String STRING_ENUMS = "stringEnums"; | |||
public static final String STRING_ENUMS_DESC = "Generate string enums instead of objects for enum values."; | |||
|
|||
protected String ngVersion = "7.0.0"; | |||
protected String ngVersion = "8.0.0"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert the default version to 7.0.0
to avoid a breaking change and have this feature released in the next release
protected String ngVersion = "8.0.0"; | |
protected String ngVersion = "7.0.0"; |
@Veluria thanks for your PR! |
please run |
Thanks for your fast response. I did run the script, but no files were changed, I guess. :) |
bin/typescript-angular-v8-petstore-provided-in-root-with-npm.json
Outdated
Show resolved
Hide resolved
Added! I was wondering about this too, but it wasn't in the previous version, so I wasn't sure if it should go there. |
@Veluria thanks for the PR, which has been included in the v4.1.1 release: https://twitter.com/oas_generator/status/1165944867391860737 |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master
,4.1.x
,5.0.x
. Default:master
.Description of the PR
After the issue regarding the http client has been sorted out, the only step for Angular 8 support are the missing libraries, which I have added here. If there's anything wrong, please let me know. Not sure what to do about the petshop examples.
@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @nicokoenig @topce @akehir