Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript-angular: Add correct library versions for Angular 8.0.0 #3619

Merged
merged 4 commits into from
Aug 12, 2019

Conversation

steffen678
Copy link
Contributor

@steffen678 steffen678 commented Aug 12, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

After the issue regarding the http client has been sorted out, the only step for Angular 8 support are the missing libraries, which I have added here. If there's anything wrong, please let me know. Not sure what to do about the petshop examples.

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @nicokoenig @topce @akehir

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -52,7 +52,7 @@
public static final String STRING_ENUMS = "stringEnums";
public static final String STRING_ENUMS_DESC = "Generate string enums instead of objects for enum values.";

protected String ngVersion = "7.0.0";
protected String ngVersion = "8.0.0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert the default version to 7.0.0 to avoid a breaking change and have this feature released in the next release

Suggested change
protected String ngVersion = "8.0.0";
protected String ngVersion = "7.0.0";

@macjohnny
Copy link
Member

@Veluria thanks for your PR!

@macjohnny macjohnny changed the title Add correct library versions for Angular 8.0.0 typescript-angular: Add correct library versions for Angular 8.0.0 Aug 12, 2019
@macjohnny macjohnny added this to the 4.1.1 milestone Aug 12, 2019
@macjohnny
Copy link
Member

@Veluria

Not sure what to do about the petshop examples.

please run bin/typescript-angular-petstore-all.sh and commit the changed files in the samples folder

@steffen678
Copy link
Contributor Author

@Veluria

Not sure what to do about the petshop examples.

please run bin/typescript-angular-petstore-all.sh and commit the changed files in the samples folder

Thanks for your fast response. I did run the script, but no files were changed, I guess. :)

@macjohnny
Copy link
Member

macjohnny commented Aug 12, 2019

Thanks for your fast response. I did run the script, but no files were changed, I guess. :)

this what we would expect as the version still defaults to 7.0.0 now.
In order to allow reviewing the generated 8.0.0 specific code, you could duplicate
https://github.com/OpenAPITools/openapi-generator/blob/master/bin/typescript-angular-v7-petstore-provided-in-root-with-npm.sh

and add it to
https://github.com/OpenAPITools/openapi-generator/blob/master/bin/typescript-angular-petstore-all.sh (don't forget the windows version https://github.com/OpenAPITools/openapi-generator/blob/master/bin/windows/typescript-angular-petstore-all.bat)

moreover, you could duplicate https://github.com/OpenAPITools/openapi-generator/blob/master/samples/client/petstore/typescript-angular-v7-provided-in-root/pom.xml with the corresponding tests
and add it to
https://github.com/OpenAPITools/openapi-generator/blob/master/pom.xml#L1064

to have the version 8.0.0 client also tested by the CI

@steffen678
Copy link
Contributor Author

Added! I was wondering about this too, but it wasn't in the previous version, so I wasn't sure if it should go there.

@wing328
Copy link
Member

wing328 commented Aug 26, 2019

@Veluria thanks for the PR, which has been included in the v4.1.1 release: https://twitter.com/oas_generator/status/1165944867391860737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants