Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java-client] set collection to null when not required #3615

Conversation

jmini
Copy link
Member

@jmini jmini commented Aug 12, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fixes #3585

@auto-labeler
Copy link

auto-labeler bot commented Aug 12, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@jmini
Copy link
Member Author

jmini commented Aug 13, 2019

cc Java technical committee:
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04)

pom.xml Outdated Show resolved Hide resolved
@wing328
Copy link
Member

wing328 commented Aug 13, 2019

@jmini I remember working on something similar and use nullable to determine the default value (null or empty list)

@wing328
Copy link
Member

wing328 commented Aug 13, 2019

Related discussion/issue: #1861

@jmini
Copy link
Member Author

jmini commented Aug 14, 2019

I remember working on something similar and use nullable to determine the default value (null or empty list)

As I wrote in issue #3585 this PR is aligning Java/pojo.mustache with JavaJaxRS/pojo.mustache

I will contribute to the discussion in #1861

@wing328
Copy link
Member

wing328 commented Aug 14, 2019

As I wrote in issue #3585 this PR is aligning Java/pojo.mustache with JavaJaxRS/pojo.mustache

Yes, I read that before leaving my comment. I'm not against this PR. Just want to share I've worked on something similar before with the nullable attribute.

@wing328 wing328 added this to the 4.1.1 milestone Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[java][model] Collection initialized to empty collection even if not required
2 participants