Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor enhancement to the README #31

Merged
merged 8 commits into from
May 14, 2018
Merged

Minor enhancement to the README #31

merged 8 commits into from
May 14, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 13, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

@wing328 wing328 added this to the 3.0.0 milestone May 13, 2018
@jimschubert
Copy link
Member

@wing328 I resolved the merge conflict related to the addition of the gitter im badge to the README. It looks like you've been making additional tweaks to this branch. I think it can be merged as soon as you're ready.

@wing328 wing328 merged commit a1ba198 into master May 14, 2018
@wing328 wing328 deleted the minor_fix branch May 18, 2018 03:25
aserkes pushed a commit to aserkes/openapi-generator that referenced this pull request Aug 12, 2022
* trigger GitHub actions

Signed-off-by: tvallin <thibault.vallin@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants