[csharp] Add an option to make API response headers dictionary case insensitive #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rator into csharp-caseinsensitive-responseheaders
|
@saigiridhar21 thanks for the PR, which has been merged into master. Do you mind adding the same feature to the csharp-netcore generator as well? |
|
Sure. Thanks for merging all the pull requests.
Just one more below pull request is pending. Please take a look when you
get time.
#3002
…On Wed, May 29, 2019 at 5:10 PM William Cheng ***@***.***> wrote:
@saigiridhar21 <https://github.com/saigiridhar21> thanks for the PR,
which has been merged into master.
Do you mind adding the same feature to the csharp-netcore generator as
well?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2998?email_source=notifications&email_token=ACPGYI5CYX2345YOI6RTABTPXZTTBA5CNFSM4HPUN5Z2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWPBT7Y#issuecomment-496900607>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACPGYI36KBW2UTD2VEWZMMDPXZTTBANCNFSM4HPUN5ZQ>
.
|
jimschubert
added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Jun 5, 2019
* 4.1.x: (56 commits) sync master Update compatibility table Ruby client: escape path parameters (OpenAPITools#3039) [gradle plugin] Release 4.0.1 fixes (OpenAPITools#3051) Update version to 4.0.2-SNAPSHOT (OpenAPITools#3047) Map number to double time since float is also parsed as double in Qt5 C++ (OpenAPITools#3046) Prepare 4.0.1 release (OpenAPITools#3041) [gradle] Reworking publishing pipeline (OpenAPITools#2886) [typescript-fetch] Fix uploading files (OpenAPITools#2900) Resolves OpenAPITools#2962 - Add properties config to Maven parameters (OpenAPITools#2963) fix(golang): Check error of xml Encode (OpenAPITools#3027) [C++][Restbed] Add handler callback methods (OpenAPITools#2911) Remove null checks for C# value types (OpenAPITools#2933) [python-server] Support python 3.7 for all server-generators (OpenAPITools#2884) Use golang's provided method names (gin) (OpenAPITools#2983) [python] Adding constructor parameters to Configuration and improving documentation (OpenAPITools#3002) Add new option to maven plugin's readme (OpenAPITools#3025) Engine param in maven plugin. (OpenAPITools#2881) Added support for patterns on model properties (OpenAPITools#2948) [csharp] Make API response headers dictionary case insensitive (OpenAPITools#2998) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
#2997
As HTTP headers are case insensitive, it is better to make API response's header dictionary as case insensitive. This is a good to have feature. Used
StringComparer.OrdinalIgnoreCasewhich has compatibility with all versions of dotnet supported by this client library.@mandrean (2017/08), @jimschubert (2017/09)