Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gradle] Display non-Stable generator stability in parens on openApiGenerators task #2826

Merged
merged 1 commit into from
May 6, 2019

Conversation

jimschubert
Copy link
Member

…enerators task

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Related to #2816, this appends any non-Stable value for the stability option of a generator. It wasn't included in #2816 because the gradle plugin is "built" alongside the maven project, but this doesn't allow the gradle plugin to reference the 4.0.0-SNAPSHOT version of code which was currently in-progress during build. We have another issue tracking the rework of how we do gradle builds, so rather than looking into that I've just done the work iteratively.

To evaluate locally, build the project as normally:

  • mvn clean install
  • cd modules/openapi-generator-gradle-plugin/
  • ./gradlew install
  • cd samples/cd local-spec/
  • gradle -q openApiGenerators -PopenApiGeneratorVersion=4.0.0-SNAPSHOT

Sample:

CLIENT generators:
    - ada
    - android
    - apex
    - bash
    - c
    - clojure
    - cpp-qt5-client
    - cpp-restsdk
    - cpp-tizen
    - csharp
    - csharp-dotnet2 (deprecated)
    …
    - scala-httpclient-deprecated (deprecated)
    - swift2-deprecated (deprecated)
    - swift3-deprecated (deprecated)

@auto-labeler
Copy link

auto-labeler bot commented May 5, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@jimschubert jimschubert merged commit e34e854 into master May 6, 2019
@jimschubert jimschubert deleted the log-non-stable-gradle-plugin branch May 6, 2019 12:35
@wing328 wing328 changed the title [gradle] Display non-Stable generator stability in parens on openApiG… [gradle] Display non-Stable generator stability in parens on openApiGenerators task May 9, 2019
@wing328 wing328 added this to the 4.0.0 milestone May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants