Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp-dotnet2] REMOVED #2786

Closed
wants to merge 2 commits into from
Closed

[csharp-dotnet2] REMOVED #2786

wants to merge 2 commits into from

Conversation

jimschubert
Copy link
Member

@jimschubert jimschubert commented May 1, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Removes C# 2.0 support. See #116

Per Microsoft Product Lifecycle, support for .NET Framework 2.0 ended in 2011:

Support for .NET Framework 2.0 ended on July 12, 2011. .NET 3.5 SP1 is the only supported service pack level after this date. We strongly encourage customers to migrate to .NET Framework 3.5 SP1. For more information, please visit the .NET Framework Support Lifecycle Policy FAQ https://support.microsoft.com/help/17455

cc @OpenAPITools/openapi-generator-core-team @mandrean (2017/08), @jimschubert (2017/09)

@jimschubert jimschubert added this to the 4.0.0 milestone May 1, 2019
@etherealjoy
Copy link
Contributor

Finally :)

@wing328
Copy link
Member

wing328 commented May 2, 2019

I think the main use case of C# 2.0 is for Unity and there's a discussion about refactoring/rewriting it: #853.

(I did talk to some users before and they said the output (C# .net 2.0 client) is functional)

@jimschubert
Copy link
Member Author

I might be wrong, but I believe Unity was up to C# 4.0 in 2016 or 2017.

@wing328
Copy link
Member

wing328 commented May 3, 2019

I've filed #2804 to add a warning instead.

@jimschubert
Copy link
Member Author

I didn't realize the generator was never "deprecated" after discussion in #116. I'll keep this open and apply a 5.0.0 target once that milestone is created.

@wing328
Copy link
Member

wing328 commented May 6, 2019

@jimschubert I believe we can close this one, right?

@jimschubert
Copy link
Member Author

@wing328 yeah, we can just redo it for a 5.0.0 release.

@jimschubert jimschubert closed this May 6, 2019
@wing328 wing328 mentioned this pull request Nov 4, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants