Minor code review fixes (JAX-RS, JS Flow) #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T is hiding a field from type AbstractTypeScriptClientCodegen”
…ns is hiding a field from type DefaultCodegen”
reference or use the href syntax”
jimschubert
added a commit
that referenced
this pull request
Apr 13, 2019
* master: (47 commits) [Slim] Fix AbstractAuthenticator constructor TypeError (#2641) Fix issue 1340 - StaticHtmlGenerator to allow snake_case property names (#2612) Test Gradle plugin in Appveyor CI (#2651) Add Camptocamp to company list (#2652) Use percent encoding for path parameters (#2649) Unescape HTML characters in JS docstring (#2636) [ONLINE] Minor links fix (#2644) better handling of undefined inner property in array (#2635) Fix regexp error on php-slim (#2604) [TypeScript-Fetch] Generate oneOf schemas as type unions (#2617) Add Namsor as the sponsor (#2639) fix classname in website (#2638) Code review fixes (#2633) Move Ruby module/gem to codegen constant (#2621) Add sponsor section to the website (#2634) [Spring] Spotbugs static class and default encoding (#2609) Add @Zomzog (2019/04) to Java, Kotlin tech comm (#2630) [maven] remove validateSpec (#2614) Clean up the license field in various templates to ensure it's unlicense by default. (#2627) Fix NPE when server url is null (#2628) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Based on previous findings in this project we decided to apply certain code quality rules.
I have configured my local IDE to check for them (code analysis report).
This PR fixes some of them, the changes are really small.