-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHP-Lumen] Lumen 5.6 support #212
Conversation
I've added WIP label |
I'll review this PR later today. 👀 |
Ran the sample locally and saw a following error: $ php artisan serve
In web.php line 77:
syntax error, unexpected '*', expecting end of file web.php line 77 -> https://github.com/OpenAPITools/openapi-generator/pull/212/files#diff-e19e515da10035a7c599677e0774c708R77 It caused by |
The error occurs also in latest master.
|
@ackintosh thanks for testing it. I would suggest a quick fix by removing that line for the time being to make the output functional first and then we'll deal with it later with escaping or other approaches. |
@wing328 Totally agree with you. I'll work for the quick fix on master branch later. |
@ackintosh I've just removed Output-Format from route.mustache and update the samples. Please pull the latest and run another test to see if the output looks good from your perspective. |
@wing328 I've added some commits and now the samples seems work fine. |
I've changed the base branch as this PR includes breaking changes. |
just fyi. in pr#343 I'm trying to add back output format by skip * / injection. |
* Lumen 5.6 support * recall headlines * Update composer.mustache * regenerate lumne php petstore samples * remove output format from lumen routes * Fix: "A facade root has not been set" * Ignore log folder
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
.Description of the PR
Cherry-picking #114
Credits: @Lv-Yi
I'll update the samples tomorrow and do some tests.