Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #16412 elixir outer enum bug #20587

Conversation

montague
Copy link
Contributor

@montague montague commented Feb 4, 2025

This fixes a bug where an outer enum isn't properly deserialized in the generated Elixir client. See this issue. #16412

I added one test to exercise the failure case, which I got from this PR #19435 as I was searching to see if anyone else had been having the same problem I ran into.

@tobbbles I grabbed your failing test from #19435 and included it here to speed things up. Thank you for your prior work on this. It pointed me in the right direction.

Real team effort here!

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Relates to #16412

This PR fixes a bug in the Elixir generator @mrmstn

Copy link
Contributor

@mrmstn mrmstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @montague,
Thanks for the PR and the fix of the issue. LGTM and pipline is green as well

Given the error description of #16412 (comment) I think this won't break anything and should fix the enum issue.

I'll check if I can merge this in the upcomimng days, so this will be included in the next release

@mrmstn mrmstn added this to the 7.12.0 milestone Feb 4, 2025
@mrmstn mrmstn self-assigned this Feb 4, 2025
@mrmstn mrmstn merged commit 8998d83 into OpenAPITools:master Feb 4, 2025
16 checks passed
@tobbbles
Copy link
Contributor

tobbbles commented Feb 4, 2025

Amazing work, thank you! I'm going to test generating the ory SDKs from this commit, and validate that end use cases work.

@montague
Copy link
Contributor Author

montague commented Feb 4, 2025

I realized I may have only fixed a part of the issue. Keep me updated on your use case @tobbbles.

@montague montague deleted the bug-fix-16412-elixir-broken-enum-generator branch February 4, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants