Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring] Resolve default value issue with Lombok Builder #18690

Closed
wants to merge 3 commits into from

Conversation

levitin
Copy link

@levitin levitin commented May 16, 2024

Resolving #18689

@levitin levitin changed the title #18689: Resolve default value issue with Lombok Builder #18689: [spring] Resolve default value issue with Lombok Builder May 19, 2024
@levitin levitin changed the title #18689: [spring] Resolve default value issue with Lombok Builder [Spring] Resolve default value issue with Lombok Builder May 19, 2024
@wing328
Copy link
Member

wing328 commented May 21, 2024

thanks for the PR

can you please update the samples as well as requested in step 3 of the PR checklist?

cc
@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)

@martin-mfg
Copy link
Contributor

Hi @levitin,
thanks for the PR!

Unfortunately, the updated java-camel sample doesn't compile. Running maven compile in samples/server/petstore/java-camel/ results in the error message "package lombok.Builder does not exist". Please fix this.

I will create a PR to have the java-camel sample automatically tested as part of the PR checks in the future.

@martin-mfg martin-mfg mentioned this pull request Jul 4, 2024
5 tasks
@rethab
Copy link

rethab commented Oct 11, 2024

Can this get merged now, or what are we missing here? @levitin @wing328

@martin-mfg
Copy link
Contributor

Can this get merged now, or what are we missing here? @levitin @wing328

As a replacement for this PR I created #19855 and resolved there the problem I mentioned in my comment above.

@rethab
Copy link

rethab commented Oct 16, 2024

Awesome, @martin-mfg . Anything I can help with to get it merged?

@wing328
Copy link
Member

wing328 commented Jan 9, 2025

closed via #19855

@rethab thanks for the PR

@wing328 wing328 closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants