Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elixir] Decode list with primitives #1536

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

mrmstn
Copy link
Contributor

@mrmstn mrmstn commented Nov 23, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

In case a endpoint responds with a list of primitiv, the current elixir codegen tries to decode thouse to a struct which does not exist.

For example:
The following should return a list of strings, this is what the codegen does (take a note at: %SwaggerPetstore.Model.String{}:

  @spec get_invoice(Tesla.Env.client, String.t, keyword()) :: {:ok, list(String.t)} | {:error, Tesla.Env.t}
  def get_invoice(connection, invoice_item_id, _opts \\ []) do
    %{}
    |> method(:get)
    |> url("/invoice/#{invoice_item_id}")
    |> Enum.into([])
    |> (&Connection.request(connection, &1)).()
    |> decode([%SwaggerPetstore.Model.String{}])
  end

This is what it does with this PR

  @spec get_invoice(Tesla.Env.client, String.t, keyword()) :: {:ok, list(String.t)} | {:error, Tesla.Env.t}
  def get_invoice(connection, invoice_item_id, _opts \\ []) do
    %{}
    |> method(:get)
    |> url("/invoice/#{invoice_item_id}")
    |> Enum.into([])
    |> (&Connection.request(connection, &1)).()
    |> decode([])
  end

To reproduce this, I made a small swagger sample - would be awesome if we coulde add this somehow to the samples

---
swagger: "2.0"
info:
  version: "1.0.0"
  title: "Swagger Petstore"
host: "petstore.swagger.io"
basePath: "/v2"
tags:
  - name: "invoice"
schemes:
  - "http"
paths:
  /invoice/{invoiceItemId}:
    get:
      tags:
        - "invoice"
      operationId: "getInvoice"
      parameters:
        - name: invoiceItemId
          in: path
          required: true
          type: string
      responses:
        200:
          description: successful operation
          schema:
            type: array
            items:
              type: string

cc: @wing328

@wing328 wing328 added this to the 3.3.4 milestone Nov 27, 2018
@wing328 wing328 merged commit 247bd68 into OpenAPITools:master Nov 27, 2018
@wing328 wing328 changed the title [elixir] Decode list with primitivs [elixir] Decode list with primitives Nov 30, 2018
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants