Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swift4] Add ability to pass in a dedicated queue for processing network response (Fix for 230) #1464

Closed
wants to merge 2 commits into from

Conversation

aplikianer
Copy link

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix for #230

Updates Swift4 templates to support the ability to pass in a dedicated queue for processing network response

cc @jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @d-date (2018/03) for review

@joeboyscout04
Copy link
Contributor

@aplikianer I'm interested in getting this merged also. Could you resolve the conflicts and see if we can get a maintainer to merge?

@4brunu
Copy link
Contributor

4brunu commented Dec 3, 2019

@aplikianer A similar PR #4591 as been merged that does something kind of similar.
It allows to choose a global DispatchQueue that is used to process all network responses.
Your PR also allows to choose a DispatchQueue per request.
Is #4591 enough for you, or do you still need this PR?
If you need this PR, can you please fix the conflicts?

@wing328
Copy link
Member

wing328 commented Jan 2, 2020

The fix is available in the newly-added swift5 generator so closing this one instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants