Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP-Symfony] Fix wrong PHP Symfony typehint #1453

Merged

Conversation

LudoMon
Copy link
Contributor

@LudoMon LudoMon commented Nov 15, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

fix #1272

A model with an array property used to have the wrong PHP typehint in the setter: the array item object type instead of "array"

This is visible in the samples, in the Pet.php model: setPhotoUrls and setTags

@jebentier, @dkarlovi, @mandrean, @jfastnacht, @ackintosh, @ybelenko

A model with an array property used to have the wrong PHP typehint in
the setter: the array item object type instead of "array"
@wing328
Copy link
Member

wing328 commented Nov 15, 2018

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@LudoMon
Copy link
Contributor Author

LudoMon commented Nov 16, 2018

Thanks a lot for this feedback 😄

I've just added the e-mail of this commit as my account secondary e-mail, I think this solves the problem

Copy link
Contributor

@ackintosh ackintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM 👍

@ackintosh
Copy link
Contributor

ackintosh commented Nov 16, 2018

https://travis-ci.org/OpenAPITools/openapi-generator/builds/455393376

The job exceeded the maximum time limit for jobs, and has been terminated.

Restarted the job. 👷

@wing328
Copy link
Member

wing328 commented Nov 18, 2018

The Travis CI failure is due to the installation of Dart 2.1 (released a few days ago) so it can be ignored for now.

@wing328 wing328 merged commit 7f8ff35 into OpenAPITools:master Nov 18, 2018
Copy link
Contributor

@ybelenko ybelenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct. 👍

@wing328 wing328 changed the title [PHP-Symfony] fix #1272 Fix wrong PHP Symfony typehint [PHP-Symfony] Fix wrong PHP Symfony typehint Nov 30, 2018
@wing328
Copy link
Member

wing328 commented Dec 4, 2018

@LudoMon thanks for the PR, which has been included in the v3.3.4 release: https://twitter.com/oas_generator/status/1068772409795207168

@LudoMon
Copy link
Contributor Author

LudoMon commented Dec 7, 2018

@wing328 I'm glad I could contribute, thank you for your work on this project 😸

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
A model with an array property used to have the wrong PHP typehint in
the setter: the array item object type instead of "array"
@wing328
Copy link
Member

wing328 commented May 25, 2022

#11810 has been merged to support Symfony 6. Please give it a try and let us know if you've any feedback or question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PHP-Symfony] Wrong type hint in model setter
4 participants