-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHP-Symfony] Fix wrong PHP Symfony typehint #1453
[PHP-Symfony] Fix wrong PHP Symfony typehint #1453
Conversation
A model with an array property used to have the wrong PHP typehint in the setter: the array item object type instead of "array"
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
Thanks a lot for this feedback 😄 I've just added the e-mail of this commit as my account secondary e-mail, I think this solves the problem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! LGTM 👍
https://travis-ci.org/OpenAPITools/openapi-generator/builds/455393376
Restarted the job. 👷 |
The Travis CI failure is due to the installation of Dart 2.1 (released a few days ago) so it can be ignored for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct. 👍
@LudoMon thanks for the PR, which has been included in the v3.3.4 release: https://twitter.com/oas_generator/status/1068772409795207168 |
@wing328 I'm glad I could contribute, thank you for your work on this project 😸 |
A model with an array property used to have the wrong PHP typehint in the setter: the array item object type instead of "array"
#11810 has been merged to support Symfony 6. Please give it a try and let us know if you've any feedback or question. |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change.master
,3.4.x
,4.0.x
. Default:master
.Description of the PR
fix #1272
A model with an array property used to have the wrong PHP typehint in the setter: the array item object type instead of "array"
This is visible in the samples, in the Pet.php model:
setPhotoUrls
andsetTags
@jebentier, @dkarlovi, @mandrean, @jfastnacht, @ackintosh, @ybelenko