Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'bin/ensure-up-to-date' script and update Shippable CI #136

Merged
merged 11 commits into from
May 24, 2018

Conversation

jmini
Copy link
Member

@jmini jmini commented May 23, 2018

Fix for #80

jmini added 2 commits May 23, 2018 17:45
* Do no longer copy 'CI/pom.xml.shippable' to 'pom.xml'
* Fix paths in CI/pom.xml.shippable
@jmini jmini force-pushed the issue80_ensure_samples_up-to-date branch from 3e79519 to dbc85d9 Compare May 23, 2018 16:54
@jmini
Copy link
Member Author

jmini commented May 23, 2018

Build of aa320fe now looks like the way I expect.

Shippable — Run 345 status is FAILED.

With this in the logs:

UNCOMMITTED CHANGES ERROR
There are uncommitted changes in working tree after execution of 'bin/ensure-up-to-date'
On branch issue80_ensure_samples_up-to-date
Your branch is up to date with 'origin/issue80_ensure_samples_up-to-date'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   samples/client/petstore/ruby/docs/FakeApi.md

no changes added to commit (use "git add" and/or "git commit -a")
Please run 'bin/ensure-up-to-date' locally and commit changes

Now I will update the outdated sample and see if the build is green.

@jmini jmini changed the title WIP Add 'bin/ensure-up-to-date' script and update Shippable CI May 23, 2018
@jmini jmini added this to the 3.0.0 milestone May 23, 2018
@jmini
Copy link
Member Author

jmini commented May 23, 2018

Build of 06e1a14 looks good to me:

Shippable — Run 350 status is SUCCESS.

And in the Logs:

./bin/ensure-up-to-date
# START SCRIPT: ./bin/ensure-up-to-date
IMPORTANT: this script ...
....
Git working tree is clean

@jmini
Copy link
Member Author

jmini commented May 24, 2018

Build error of f86bb02

Shippable — Run 357 status is FAILED.

is correct. Logs:

UNCOMMITTED CHANGES ERROR
There are uncommitted changes in working tree after execution of 'bin/ensure-up-to-date'
HEAD detached at FETCH_HEAD
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   samples/client/petstore/kotlin/README.md
	modified:   samples/server/petstore/kotlin-server/ktor/src/main/kotlin/org/openapitools/server/models/Order.kt
	modified:   samples/server/petstore/kotlin-server/ktor/src/main/kotlin/org/openapitools/server/models/Pet.kt

no changes added to commit (use "git add" and/or "git commit -a")
Please run 'bin/ensure-up-to-date' locally and commit changes

bin/kotlin-client-petstore.sh
bin/kotlin-client-string.sh
bin/kotlin-client-threetenbp.sh
bin/kotlin-server-petstore.sh
@jimschubert
Copy link
Member

@jmini it looks like you're doing some iterative verifications on this branch. Can you create/add a WIP label if this isn't ready to merge?

@jmini
Copy link
Member Author

jmini commented May 24, 2018

It is ready to merge, and the CI is green.

We can add more generators to the list of the generators we want to have covered by the check with separated PRs.

I would like to merge this now, if you agree...


I use "WIP" prefix in the title of PR when it is requested. In this case, might have noticed that the Shippable CI was only red of a couple of minutes at each iteration... I have verified the state and I have pushed the "solving commit" (the one that update the samples/ folder) right after the end of the failing job.

@jimschubert
Copy link
Member

Sounds good! I'll go ahead and merge. I wasn't sure if you were adding all generators, but I agree doing it on separate PRs.

@jimschubert jimschubert merged commit 00f176a into master May 24, 2018
@jimschubert jimschubert deleted the issue80_ensure_samples_up-to-date branch May 24, 2018 14:18
nilskuhn pushed a commit to nilskuhn/openapi-generator that referenced this pull request Apr 6, 2023
…ic-release-monorepo

chore(deps): update dependency semantic-release to v17.2.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants