-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'bin/ensure-up-to-date' script and update Shippable CI #136
Conversation
* Do no longer copy 'CI/pom.xml.shippable' to 'pom.xml' * Fix paths in CI/pom.xml.shippable
3e79519
to
dbc85d9
Compare
Build of aa320fe now looks like the way I expect.
With this in the logs:
Now I will update the outdated sample and see if the build is green. |
Build of 06e1a14 looks good to me:
And in the Logs:
|
Build error of f86bb02
is correct. Logs:
|
bin/kotlin-client-petstore.sh bin/kotlin-client-string.sh bin/kotlin-client-threetenbp.sh bin/kotlin-server-petstore.sh
@jmini it looks like you're doing some iterative verifications on this branch. Can you create/add a WIP label if this isn't ready to merge? |
It is ready to merge, and the CI is green. We can add more generators to the list of the generators we want to have covered by the check with separated PRs. I would like to merge this now, if you agree... I use "WIP" prefix in the title of PR when it is requested. In this case, might have noticed that the Shippable CI was only red of a couple of minutes at each iteration... I have verified the state and I have pushed the "solving commit" (the one that update the |
Sounds good! I'll go ahead and merge. I wasn't sure if you were adding all generators, but I agree doing it on separate PRs. |
…ic-release-monorepo chore(deps): update dependency semantic-release to v17.2.4
Fix for #80