Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Add support for m2e-integration to be capable of using #1328

Closed
wants to merge 1 commit into from
Closed

[Java] Add support for m2e-integration to be capable of using #1328

wants to merge 1 commit into from

Conversation

andreas-eternach
Copy link
Contributor

@andreas-eternach andreas-eternach commented Oct 26, 2018

OpenApi-generation from within eclipse (#509)

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. Not sure if it works by just copying the rp here like this: @jeff9finger

Description of the PR

This PR contains M2E-Integration so that the code generation can be run in eclipse

@wing328
Copy link
Member

wing328 commented Oct 26, 2018

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@andreas-eternach
Copy link
Contributor Author

Thnk you for the hint, indeed i would like to update the PR.

I am familiar with git and know how to rebase / amend, but not familliar with PRs.

Do i need to open a new PR to get the author-information into the system or can i just change the master-branch in my copy and the PR will be aligned automatically ?

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@@ -15,6 +15,11 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>
<dependencies>
<dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreas-eternach Can we use spaces instead of tabs?

@wing328
Copy link
Member

wing328 commented Oct 26, 2018

Looks like you're using tab for indentation. Please use 4-space instead

* Added life-cycle-mapping for recognition by M2E
* Make BuildContext injectable by M2E in oder to detect if json-source
has been modified and a regeneration is required.
@andreas-eternach
Copy link
Contributor Author

Closing this request, going to issue a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants