-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spring] Do not set contextPath for spring-boot #104
Conversation
The new check to ensure that
See #80 for discussion. I hope this is not a false positive. |
@jmini I simply used the Github web-based GUI to resolve the merge conflicts (to keep both import statements). I didn't touch those |
The check is also failing on |
I'll update the samples in a separate PR. |
I've run ./bin/spring-all-petstore.sh but git diff doesn't show any change. The following files are not added to the project:
I'll include these files in my next PR. |
I am not saying that my But merging a PR with a failed check is a bad idea. Now all PR integrating this commit are failing. @wing328: I also did not manage to reproduce this locally... In case of emergency like this, we can also remove the spring scripts from the list of checked generators (remove this line: openapi-generator/bin/ensure-up-to-date Line 15 in 9b86023
Can you please have a look? |
The missing files are added with #165 |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
.Description of the PR
@bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)
This fixes swagger-api/swagger-codegen#5244