Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ][typescript-redux-query] Allow client to set the base path to be prepended to endpoints in the generated query configs. #6942

Closed
stgraham2000 opened this issue Jul 14, 2020 · 3 comments · Fixed by #6943

Comments

@stgraham2000
Copy link
Contributor

Description

If you generate a client using the typescript-redux-query generator, there is no way to set the base path for the url in the generated query configs. This means you can't easily make your generated client communicate with your backend API if your client is hosted from a different domain. One option is to override the network interface but that seems wrong considering other generators allow you to update the configuration and set the BASE_PATH.

openapi-generator version

Version: 5.0.0
My working version: commit cef1bec

Suggest a fix/enhancement

My suggested fix is to create a Configuration object in the runtime.mustache that defaults a variable called basePath to an empty string. My decision for using an empty string is to keep this change backwards compatible. We then update apis.mustache prepend the runtime.Configuration.basePath to the existing value being used for the url in the query config. The below is a diff off of the commit cef1bec4666e7841c39a37eec97b2e81c96ad9f0.

@auto-labeler
Copy link

auto-labeler bot commented Jul 14, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@Fiv5
Copy link

Fiv5 commented Jul 17, 2020

ditto!

@macjohnny
Copy link
Member

@stgraham2000 would you like to file a PR?

jimschubert added a commit that referenced this issue Aug 12, 2020
* master: (27 commits)
  [WIP][python-exp] Force camelization of imports (#7186)
  Fixes #6942: Added ability to prepend a basePath to typescript-redux-query generators (#6943)
  [Typescript] Import path is invalid in windows. (#7175)
  Fix JaxRS Spec generator additional model types (#7180)
  [python{,-experimental}] Obey floating point timeouts provided to RESTClientObject.request(...) (#7154)
  [C#] Switch the spec to OAS v3 from v2 (#7176)
  [Javascript] Fixing the handling of non primitive types in paramToString (#7171) (#7172)
  [typescript-node] Fix invalid type when using node@10 and ES5 (#7133)
  Minor fix to github workflow badge
  [gradle] Enabling up-to-date checks and gradle caching for openapigenerator tasks (#6716)
  feat(csharp-netcore): Adding response headers to the ApiException (#7169)
  [ci] Verify supported JDK versions on master push (#7085)
  Issue #6830: Java server - Add getter to ApiException templates (#7150)
  update kotlin samples
  [Kotlin] Make ApiClient in jvm-retrofit2 be able to use own OkHttpClient (#6999)
  Sttp - wrap query params (#6884)
  Add a link to https://medium.com/@everisBrasil blog post (#7160)
  [C#][netcore] fix regular expression when it contains double quotes (#7147)
  remove duplicated cancellationToken in comment (#7148)
  update samples
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants