Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java-client][google-api-client] version update? #3625

Closed
jmini opened this issue Aug 13, 2019 · 3 comments · Fixed by #3882
Closed

[java-client][google-api-client] version update? #3625

jmini opened this issue Aug 13, 2019 · 3 comments · Fixed by #3882
Labels
Client: Java Enhancement: Feature

Comments

@jmini
Copy link
Member

jmini commented Aug 13, 2019

When a Java client is generated using the google-api-client library, then the version used is quite old:

openapi-generator/samples/client/petstore/java/google-api-client/pom.xml

Line 254 in 123efc5

<google-api-client-version>1.23.0</google-api-client-version>

Any reason why we are not using something newer?

        <google-api-client-version>1.30.2</google-api-client-version>

Version 1.23.0 is from "Oct, 2017"
https://mvnrepository.com/artifact/com.google.api-client/google-api-client
@auto-labeler
Copy link

auto-labeler bot commented Aug 13, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@jmini jmini mentioned this issue Aug 20, 2019
Open
@bensimpson-ch
Copy link
Contributor

@jmini I updated the dependencies in the generator and sample tests in PR #3882

wing328 pushed a commit that referenced this issue Sep 13, 2019
@bensimpson-ch @wing328
updated google-api-client version from 1.23.0 to 1.30.2. Bugfix #3625 (…
f27ff79 
…#3882)
jimschubert added a commit that referenced this issue Sep 13, 2019
@jimschubert
Merge branch 'master' into spring-requestparam-regression
3e2ec0b 
* master: (22 commits)
  various minor improvements to nim generator (#3883)
  Add Nim client code generator (#3879)
  updated google-api-client version from 1.23.0 to 1.30.2.  Bugfix #3625 (#3882)
  typescript-fetch: fix missing comma in multiple imports (#3881)
  [scala][client] add Scala code generation test (#3859)
  typescript-node: Use HttpError class when rejecting promises (#3876)
  update stable release
  update doc, samples (#3875)
  BugFix #2053 Spring Boot fails to parse LocalDate query parameter (#3860)
  fix version in readme
  Prepare v4.1.2 release (#3873)
  Rename gRPC generator to "protobuf-schema" (#3864)
  typescript-axios: Fix baseoptions (#3866)
  Fix/r/serialization fix and minor 3xx resp fix (#3817)
  [typescript-angular] allow empty string basePath (#3489)
  typescript-inversify: improve check for required parameters, support multiple media types (#3849)
  [C++][Pistache] Add missing setter for arrays (#3837)
  Adds Http Info To Dart Api (#3851)
  [Java][okhttp-gson] fix failure to deserialize floats (#3846)
  maven-plugin-plugin 3.6.0 (#3854)
  ...
@jmini
Copy link
Member Author

jmini commented Sep 16, 2019

Thank you for the contribution

@jmini jmini closed this as completed Sep 16, 2019
@bensimpson-ch bensimpson-ch mentioned this issue Oct 4, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Client: Java Enhancement: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update google-api-client version from 1.23.0 to 1.30.2
2 participants
@jmini @bensimpson-ch