Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Swift 4] unwrapRequired option doesn't do anything #228

Closed
joeboyscout04 opened this issue Jun 5, 2018 · 0 comments · Fixed by #229
Closed

[Swift 4] unwrapRequired option doesn't do anything #228

joeboyscout04 opened this issue Jun 5, 2018 · 0 comments · Fixed by #229
Labels
Client: Swift

Comments

@joeboyscout04
Copy link
Contributor

Description

It looks like the unwrapRequired config option doesn't do anything in Swift 4. It is there in Swift 3 generator but not in Swift 4. It's apparent by looking at the mustache templates for Swift 4 that that option doesn't exist anywhere in the templates.

openapi-generator version

3.0.0

Steps to reproduce

Readily reproducible in any project using this option and swift 4.

Related issues/PRs

Coming soon
@joeboyscout04 joeboyscout04 changed the title [Swift4] [Swift 4] unwrapRequired option doesn't do anything Jun 5, 2018
@joeboyscout04 joeboyscout04 mentioned this issue Jun 5, 2018
Merged
4 tasks
joeboyscout04 pushed a commit to joeboyscout04/openapi-generator that referenced this issue Nov 22, 2018
Fix OpenAPITools#228 (actually correct logic and default option)
f1fe04d
@joeboyscout04 joeboyscout04 mentioned this issue Nov 22, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Client: Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Swift 4] add compatibility for unwrapRequired config option joeboyscout04/openapi-generator
2 participants
@jimschubert @joeboyscout04