Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #264 Avoid manual update for the caption of time profile plot #271

Merged
merged 2 commits into from
May 18, 2022
Merged

Fixes #264 Avoid manual update for the caption of time profile plot #271

merged 2 commits into from
May 18, 2022

Conversation

pchelle
Copy link
Collaborator

@pchelle pchelle commented May 16, 2022

No description provided.

msevestre
msevestre requested changes May 16, 2022
View reviewed changes
R/plot-timeprofile.R
@@ -257,6 +257,7 @@ plotTimeProfile <- function(data = NULL,
getAestheticValues(
n = totalLength - colorLength,
selectionKey = plotConfiguration$points$color,
position = colorLength,
aesthetic = "color"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting a position to a number of colors is not obvious. This needs to be commented

@codecov-commenter
Copy link

Codecov Report

Merging #271 (9f9a3b2) into develop (30e8b25) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #271      +/-   ##
===========================================
- Coverage    51.53%   51.51%   -0.02%     
===========================================
  Files           51       51              
  Lines         2796     2797       +1     
===========================================
  Hits          1441     1441              
- Misses        1355     1356       +1
Impacted Files Coverage Δ
R/plot-timeprofile.R 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30e8b25...9f9a3b2. Read the comment docs.

IndrajeetPatil added a commit to Open-Systems-Pharmacology/OSPSuite-R that referenced this pull request May 17, 2022
@IndrajeetPatil
Remove function to update legend caption df
a50b555 
Made unnecessary with Open-Systems-Pharmacology/TLF-Library#271
@IndrajeetPatil IndrajeetPatil mentioned this pull request May 17, 2022
Merged
@IndrajeetPatil
Copy link
Member

@pchelle Thanks!

I can confirm that (in Open-Systems-Pharmacology/OSPSuite-R#956) that this fixes #264.

@IndrajeetPatil
Copy link
Member

This is high priority for ospsuite v11 release, and so I am merging this.

The added comment looks good, and I've already made sure that this works as expected in the open PR (Open-Systems-Pharmacology/OSPSuite-R#956).

@IndrajeetPatil IndrajeetPatil merged commit 7d1e115 into Open-Systems-Pharmacology:develop May 18, 2022
IndrajeetPatil added a commit to Open-Systems-Pharmacology/OSPSuite-R that referenced this pull request May 18, 2022
@IndrajeetPatil
Remove function to update legend caption df (#956)
d42083f 
Made unnecessary with Open-Systems-Pharmacology/TLF-Library#271
@pchelle pchelle deleted the 264_time_profile_legend branch February 15, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msevestre msevestre msevestre requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pchelle @codecov-commenter @IndrajeetPatil @msevestre