Fixes #249 allow data expansion to axes #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default value for ddi ratio is TRUE
Yuri05
reviewed
Apr 29, 2022
R/utilities-axis.R
Outdated
| #' } | ||
| #' @keywords internal | ||
| xAxisDefaultExpand <- function(plotConfiguration) { | ||
| return(isOfType(plotConfiguration, c("DDIRatioPlotConfiguration"))) |
There was a problem hiding this comment.
can we define a const for "DDIRatioPlotConfiguration" and use it here (and below) and in the class definition?
TLF-Library/R/plotconfiguration.R
Lines 286 to 288 in 7602df3
Alternatively: add tests, checking that xAxisDefaultExpand(DDIRatioPlotConfiguration$new()) and yAxisDefaultExpand(DDIRatioPlotConfiguration$new()) returns true and for other config types returns false
There was a problem hiding this comment.
can we define a const for "DDIRatioPlotConfiguration" and use it here (and below) and in the class definition?
I love this idea !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default value for ddi ratio is TRUE