Fixes #245 allow transparency for lines and points #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IndrajeetPatil , let me know if this improves the quality of the time profile plots |
|
Yes, this looks much better! Thanks a bunch. |
IndrajeetPatil
approved these changes
Apr 29, 2022
Yuri05
reviewed
Apr 29, 2022
| @@ -299,16 +301,17 @@ addLine <- function(data = NULL, | |||
| shape = "legendLabels", | |||
| fill = "legendLabels" | |||
| ), | |||
| show.legend = TRUE | |||
| show.legend = NA | |||
There was a problem hiding this comment.
@pchelle what is the impact of this change (here and below)?
There was a problem hiding this comment.
When using TRUE, I get the following weird point in the legend
addLine(x=0)
There was a problem hiding this comment.
Add a comment explaining why that is.
Remember. Don't comment the obvious. But DO comment what is unexpected
18 tasks
Yuri05
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.