-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default color map for ospsuite plots #247
Conversation
So that, in the code below, |
"#339900FF", "#00991AFF", "#009966FF", "#008099FF", "#003399FF", | ||
"#1A0099FF", "#660099FF", "#990080FF", "#D60047FF", "#FF1463FF", | ||
"#00D68FFF", "#14FFB1FF" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just out of curiosity: are those magic numbers created randomly or is there any kind of "algorithm" behind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can see the algorithm here:
https://rdrr.io/cran/ggsci/src/R/discrete-igv.R
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Following that link I found the page here with the nice overview of those colour palettes:
https://cran.r-project.org/web/packages/ggsci/vignettes/ggsci.html
Which gives some inspiration for our future extensions :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are looking for a more general overview of color palettes in R, you can see it here:
https://github.com/EmilHvitfeldt/r-color-palettes
It combines palettes from dozens of different packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. We should suggest https://github.com/aljrico/gameofthrones as our default palette to @PavelBal 😉
As discussed in Open-Systems-Pharmacology/OSPSuite-R#894
What the palette looks like:
Created on 2022-04-25 by the reprex package (v2.0.1.9000)