move plot grid function and class from ospsuite #246
Conversation
|
Not sure, why there are these issues with installing pandoc now. Failures
- pandoc (exited 1) - pandoc not installed. An error occurred during installation:
The remote server returned an error: (429) Too Many Requests. Too Many Requests
Command exited with code 1
7z a failure.zip *.Rcheck\*
7-Zip 21.07 (x64) : Copyright (c) 1999-2021 Igor Pavlov : 2021-12-26
|
|
"Too Many Requests" probably server too busy. Now the build fails only due to the |
R/plot-grid.R
Outdated
| #' | ||
| #' @examples | ||
| #' | ||
| #' library(ospsuite) |
R/plot-grid.R
Outdated
| #' @description | ||
| #' | ||
| #' R6 class defining the configuration for `{patchwork}` plot grid used to | ||
| #' create a grid of plots from `{ospsuite}`. It holds values for all relevant |
There was a problem hiding this comment.
remove from {ospsuite} or replace it with from {tlf}
|
@Yuri05 Removed the references to ospsuite, which were left in by mistake. |
Codecov Report
@@ Coverage Diff @@
## develop #246 +/- ##
===========================================
- Coverage 52.01% 51.66% -0.35%
===========================================
Files 50 51 +1
Lines 2686 2706 +20
===========================================
+ Hits 1397 1398 +1
- Misses 1289 1308 +19
Continue to review full report at Codecov.
|
To be considered after Open-Systems-Pharmacology/TLF-Library#246 is merged closes #888
|
appveyor works but not test coverage. |
|
@msevestre Yes, this is same as this issue: #241 GHA is no longer working. We either need to fix it (I unsuccessfully tried in #242) or completely remove it. |
|
Can we do code coverage like we do for all other packages? Tha way we don't rely on it anymore. We keep having issue with GHA and that's a real PIA |
|
Well, we are having issues now because we removed ospsuite.utils from CRAN, but it was working fine before. Actually, the test coverage GHA is redundant because we are already using AppVeyor for this. |
Any problems to install ospsuite.utils in GHA in the same way as in appveyor.yml? Line 55 in dd00853
I would prefer the other way around: remove code coverage from appveyor.yml but keep the GitHub action. |
|
Code coverage doesn't have to be run each time. I think we need to split it into it's own task (or have it work with GA). In general, code coverage gives you some nice metrics but isn't required to decide whether to merge a PR or not. So as for our main apps(pksim, mobi and core), I would suggest to create a specific task for this that would run on a weekly basis, especially if it takes a lot of time. Even with GHA, this is time that we do need to wait for everytime to get valuable CI feedback |
|
agree. running codecovr nightly/weekly/whatever is surely better than on every commit |
cf. Open-Systems-Pharmacology/OSPSuite-R#888