Fixes #227 ribbon transparency can be changed in all plots #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in all plots While fixing this, I also fixed a typo in runThemeMaker Besides, I found a way of centralizing and simplifying the process of defining how lines, points, ribbons are plotted
pchelle
added a commit
to pchelle/TLF-Library
that referenced
this pull request
Mar 24, 2022
This code was a fix committed in PR Open-Systems-Pharmacology#228 that may lead to a merge conflict
msevestre
approved these changes
Mar 24, 2022
IndrajeetPatil
pushed a commit
that referenced
this pull request
Mar 24, 2022
* Fixes #224 plotTimeProfile and its mapping are more versatile Now simulated and observed data can be plotted both independently or synchronized (as illustrated by vignette) with correct legend for both I also removed lloq from ObservedDataMapping that was making things complicated * Remove ggplot2 messages when aesthetic scales are updated * Export function to update time profile plot legend easily * Prevent time profile errors This code was a fix committed in PR #228 that may lead to a merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing this, I also fixed a typo in runThemeMaker
Besides, I found a way of centralizing and simplifying the process of defining how lines, points, ribbons are plotted