Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #206 restore vignette image files #215

Conversation

pchelle
Copy link
Collaborator

@pchelle pchelle commented Jan 26, 2022

Fix suggested from r-lib/pkgdown#1231

@IndrajeetPatil
Copy link
Member

Nice! Thanks for taking care of this.

@pchelle
Copy link
Collaborator Author

pchelle commented Jan 26, 2022

Nice! Thanks for taking care of this.

I am not sure this will work though. In case I found this as backup plan (but I still lack experience with github actions):
ArgoCanada/argoFloats#172

@Yuri05
Copy link
Member

Yuri05 commented Jan 26, 2022

I hope the page will be displayed black on white background and not white on black background? 😉

@pchelle
Copy link
Collaborator Author

pchelle commented Jan 26, 2022

I hope the page will be displayed black on white background and not white on black background? 😉

Should be good for {tlf}, there is still some black theming in the reporting engine documentation though.
Comparing the _pkgdown.yml files with the other packages, there is still some theme: arrow-dark among the template features

@Yuri05 Yuri05 merged commit fe4eac2 into Open-Systems-Pharmacology:develop Jan 26, 2022
@pchelle pchelle deleted the 206_vignette_broken_image_link branch February 15, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants