-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #199 Fixes #154 use log ticks and log labels #201
Fixes #199 Fixes #154 use log ticks and log labels #201
Conversation
… use log ticks and log labels
#' Scaling$date | ||
Scaling <- enum(c( | ||
"lin", | ||
"log", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to distinguish between log and log10 scaling here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is possible but not sure if we should: in the config plan, Scaling is log for log10...
I could set up a "ln" that would make the difference clearer in the Scaling enum ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep makes sense. Make sure to comment what those enum are about
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and update the overall comment #' Scaling$date
:)
Axis configurations now include 3 new public methods: * ggplotScale that provides the actual ggplot scale name * prettyTicks that will get user defined or tlf default ticks * prettyTickLabels that will get user defined or tlf default ticklabels
Codecov Report
@@ Coverage Diff @@
## develop #201 +/- ##
===========================================
+ Coverage 47.72% 47.81% +0.09%
===========================================
Files 55 55
Lines 2590 2633 +43
===========================================
+ Hits 1236 1259 +23
- Misses 1354 1374 +20
Continue to review full report at Codecov.
|
No description provided.