-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
147 plot obs vs pred #148
147 plot obs vs pred #148
Conversation
These functions return expressions which can be directly evaluated
With this logic shapes and colors can be split in the legend Also, it is now possible to include uncertainty error bars
Convenient input if you don't want/need to use a full data.frame
Codecov Report
@@ Coverage Diff @@
## develop #148 +/- ##
===========================================
+ Coverage 49.59% 50.78% +1.19%
===========================================
Files 53 54 +1
Lines 2561 2408 -153
===========================================
- Hits 1270 1223 -47
+ Misses 1291 1185 -106
Continue to review full report at Codecov.
|
DESCRIPTION
Outdated
@@ -41,6 +41,7 @@ Suggests: | |||
gridExtra | |||
VignetteBuilder: knitr | |||
Collate: | |||
'aaa.R' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is aaa.R?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functions that are used to create common R expressions (to prevent copy/paste of code) and that are not exported are stored in the script aaa.R
; but since these functions are potentially used by any of the remaining functions of the package, I wanted to ensure they are collated first, otherwise build crashes can happen.
I found that other packages used the naming of the files as a solution since they are collated in alphabetical order (e.g. ggplot2 also uses aaa-.R and ospsuite has a zzz.R).
Would something like aaa-utilities.R
be more appropriate ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, would be better
Update corresponding documentation
c1a4402
to
1a427d2
Compare
No description provided.