Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

135 theme concept #137

Merged
merged 27 commits into from
Mar 18, 2021
Merged

135 theme concept #137

merged 27 commits into from
Mar 18, 2021

Conversation

pchelle
Copy link
Collaborator

@pchelle pchelle commented Feb 25, 2021

WIP

pchelle added 20 commits February 4, 2021 09:03
@pchelle
Draft of a theme maker app
833901a
@pchelle
Include Wrapper for theme maker app
313e668
@pchelle
Remove data from internal package data
fd1047f 
For the examples and vignettes, external csv data seems much better and prevent corruption of RData types which crash R sometimes
@pchelle
Create smarter R6 Theme and related classes
e616adb 
Also aesthetic properties are split in map and how the plots can use the map
@pchelle
Fixes and reconcile plot configuration with new theme workflow
08e9c0b
@pchelle
Fixes atom plots with new plot configurations and themes
599901a 
Also errorbar has been redesigned
@pchelle
Provide user interface drafts for molecule plots
c7b44ca 
The end goal is to also include them in vignettes
@pchelle
A test data set and theme template available in extdata
d877838
@pchelle
Fix boxplots with new theme configuration
1faea9e
@pchelle
Fix histograms with new theme configuration
daa4212
@pchelle
Fix pk and ddi ratio plots with new theme configuration
dafa563
@pchelle
Fix time profile and obs vs pred plots with new theme configuration
444e0ad
@pchelle
Throw a warning when data has no row in input
079d59f
@pchelle
Provide default for all plot configurations
c922322
@pchelle
Update tornado plot
a78c0c4
@pchelle
Add mapping defaults
966ac79
@pchelle
Fix tests
989fed0
@pchelle
Fix vignettes
0d4a4b2
@pchelle
Update namespace with the app wrappers
160df3e
@pchelle
add example data and meta data in extdata
004049c
@codecov-io
Copy link

Codecov Report

Merging #137 (ead7e0f) into develop (24c309b) will increase coverage by 0.50%.
The diff coverage is 46.07%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #137      +/-   ##
===========================================
+ Coverage    48.28%   48.79%   +0.50%     
===========================================
  Files           52       53       +1     
  Lines         1775     2562     +787     
===========================================
+ Hits           857     1250     +393     
- Misses         918     1312     +394
Impacted Files Coverage Δ
R/boxwhisker-datamapping.R 0.00% <0.00%> (ø)
R/boxwhisker-plotconfiguration.R 0.00% <0.00%> (ø)
R/datamapping-range.R 62.06% <ø> (ø)
R/ddiratio-datamapping.R 0.00% <0.00%> (ø)
R/histogram-datamapping.R 0.00% <0.00%> (ø)
R/histogram-plotconfiguration.R 0.00% <0.00%> (ø)
R/obs-vs-pred-datamapping.R 0.00% <0.00%> (ø)
R/obs-vs-pred-plotconfiguration.R 0.00% <0.00%> (ø)
R/observed-data-mapping.R 0.00% <0.00%> (ø)
R/plot-boxwhisker.R 0.00% <0.00%> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c309b...ead7e0f. Read the comment docs.

@msevestre msevestre merged commit 2a18623 into Open-Systems-Pharmacology:develop Mar 18, 2021
@pchelle pchelle deleted the 135-theme-concept branch August 5, 2021 06:47
@pchelle pchelle mentioned this pull request Apr 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pchelle @codecov-io @msevestre