Support for Exception handling #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SettingsForConcurrentRunSimulationBatch
PavelBal
approved these changes
Apr 27, 2021
msevestre
requested changes
Apr 27, 2021
| e.Message | ||
| ); | ||
| } | ||
| return new ConcurrencyManagerResult<TResult> |
There was a problem hiding this comment.
why don't you return this from the try?
Also can you not name the parameter args
Last, don't hesitate to name parameters instead of passing false, or true => success: true
| { | ||
| Id = id; | ||
| Succeeded = succeeded; | ||
| ErrorMessage = error; |
There was a problem hiding this comment.
Either call the parameter errorMessage or the Member Error. No reason to have different names here.
| ( | ||
| id(args), | ||
| true, | ||
| simulationResult, |
There was a problem hiding this comment.
It feels like two constructor. One with Id(artgs) results and there other one just with the id(args)and error instead of asking the caller to pass the right parameters. (e.g. "", false or null true etc..)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.