831 reverse command #834
Merged
831 reverse command #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
commented
Oct 23, 2020
| @@ -93,7 +93,7 @@ public interface IReversibleCommand<in TExecutionContext> : ICommand<TExecutionC | |||
| /// <summary> | |||
| /// Create an inverse for the current command | |||
| /// </summary> | |||
| IReversibleCommand<TExecutionContext> InverseCommand(TExecutionContext context); | |||
| ICommand<TExecutionContext> InverseCommand(TExecutionContext context); | |||
There was a problem hiding this comment.
@Yuri05 I am changing this to not require the undo command to also be undoable. That way we can have the best of both worlds
| @@ -25,7 +25,7 @@ public static bool IsEmpty(this ICommand command) | |||
| public static bool IsEmptyMacro(this ICommand command) | |||
| { | |||
| var macroCommand = command as IMacroCommand; | |||
| return macroCommand != null && macroCommand.IsEmtpy; | |||
There was a problem hiding this comment.
We've had this typo since the beginning!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.