Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison of passive transports: difference in "Create process rate" flag is not shown #2394 #2395

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Comparison of passive transports: difference in "Create process rate" flag is not shown #2394 #2395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/OSPSuite.Core/Comparison/ReactionBuilderDiffBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ public override void Compare(IComparison<ReactionBuilder> comparison)
_enumerableComparer.CompareEnumerables(comparison, x => x.Products, item => item.MoleculeName);
_enumerableComparer.CompareEnumerables(comparison, x => x.ModifierNames, item => item, missingItemType: ObjectTypes.Modifier);
CompareValues(x => x.ContainerCriteria, x => x.ContainerCriteria, comparison);
CompareValues(x => x.CreateProcessRateParameter, x => x.CreateProcessRateParameter, comparison);
_objectComparer.Compare(comparison.DimensionComparison());
}
}
Expand Down
1 change: 1 addition & 0 deletions src/OSPSuite.Core/Comparison/TransporterBuilderDiffBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ public override void Compare(IComparison<TransportBuilder> comparison)
CompareValues(x => x.TargetCriteria, x => x.TargetCriteria, comparison);
_objectComparer.Compare(comparison.DimensionComparison());
_moleculeDependentBuilderDiffBuilder.Compare(comparison);
CompareValues(x => x.CreateProcessRateParameter, x => x.CreateProcessRateParameter, comparison);
_objectComparer.Compare(comparison.FormulaComparison());
}
}
Expand Down
29 changes: 29 additions & 0 deletions tests/OSPSuite.Core.IntegrationTests/DiffBuilders/ReactionBuilderDiffBuilderSpecs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,35 @@ public void should_return_no_differences()
}
}

public class When_comparing_reactions_having_different_create_process_rate_parameter_values : concern_for_ObjectComparer
{
protected override void Context()
{
base.Context();
var f1 = new ExplicitFormula("CL*conc").WithName("formula");
var r1 = new ReactionBuilder().WithName("Reaction").WithFormula(f1);
r1.AddEduct(new ReactionPartnerBuilder("Drug", 1));
r1.AddEduct(new ReactionPartnerBuilder("Metab", 1));
var p11 = new Parameter().WithName("P1").WithFormula(new ConstantFormula(2)).WithParentContainer(r1);
r1.CreateProcessRateParameter = true;

var f2 = new ExplicitFormula("CL*conc").WithName("formula");
var r2 = new ReactionBuilder().WithName("Reaction").WithFormula(f2);
r2.AddEduct(new ReactionPartnerBuilder("Drug", 1));
r2.AddEduct(new ReactionPartnerBuilder("Metab", 1));
var p12 = new Parameter().WithName("P1").WithFormula(new ConstantFormula(2)).WithParentContainer(r2);

_object1 = r1;
_object2 = r2;
}

[Observation]
public void should_report_the_differences_accordingly()
{
_report.Count.ShouldBeEqualTo(1);
}
}

public class When_comparing_reactions_having_the_same_formula_but_different_modifiers : concern_for_ObjectComparer
{
protected override void Context()
Expand Down
20 changes: 20 additions & 0 deletions tests/OSPSuite.Core.IntegrationTests/DiffBuilders/TransportBuilderDiffBuilderSpecs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,26 @@ public void should_report_the_differences_accordingly()
}
}

public class When_comparing_Transports_with_different_for_create_process_rate : concern_for_ObjectComparer
{
protected override void Context()
{
base.Context();
var t1 = new TransportBuilder().WithName("Passive");
var t2 = new TransportBuilder().WithName("Passive");
t1.CreateProcessRateParameter = true;

_object1 = t1;
_object2 = t2;
}

[Observation]
public void should_report_the_differences_accordingly()
{
_report.Count.ShouldBeEqualTo(1);
}
}

public class When_comparing_Transports_with_different_for_all_settings : concern_for_ObjectComparer
{
protected override void Context()
Expand Down