Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2327 comparison of simulation with bb when a parameter is distributed in the bb bot not in the simulation #2337

Conversation

rwmcintosh
Copy link
Member

Fixes #2327

Description

Adding a "Not Distributed" for comparison view when comparing a distributed vs. non distributed PathAndValueEntity

Type of change

Please mark relevant options with an x in the brackets.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires documentation changes (link at least one user or developer documentation issue):
  • Algorithm update - updates algorithm documentation/questions/answers etc.
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Integration tests
  • Unit tests
  • Manual tests
  • No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

  • Check if the code is well documented
  • Check if the behavior is what is expected
  • Check if the code is well tested
  • Check if the code is readable and well formatted
  • Additional checks (document below if any)
  • Check if documentation update issue(s) are created if the option This change requires a documentation update above is selected

Screenshots (if appropriate):

image

Questions (if appropriate):

@@ -30,7 +31,9 @@ protected virtual void ComparePathAndEntityValues(IComparison<T> comparison)
// of a distributed PathAndValueEntity is not fully calculated until it is turned into
// a parameter
if(!comparison.Object1.DistributionType.Equals(comparison.Object2.DistributionType))
CompareValues(x => x.DistributionType, x => x.DistributionType, comparison);
CompareValues(x => x.DistributionType, x => x.DistributionType, comparison,
areEquals: (type1, type2) => Equals(type2, type1),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we rename the argument areEquals to areEqual?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, done

@rwmcintosh rwmcintosh merged commit 3308a19 into develop Oct 17, 2024
1 check passed
@rwmcintosh rwmcintosh deleted the 2327-comparison-of-simulation-with-bb-when-a-parameter-is-distributed-in-the-bb-bot-not-in-the-simulation branch October 17, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Verified
Development

Successfully merging this pull request may close these issues.

Comparison of simulation with BB when a parameter is distributed in the BB bot not in the simulation
2 participants