#2256 Add new Exception and change message to show Module

[benjaperez1983]

Fixes #2256

Description

Changed the way we display the message for this exception by adding the module and building block information to it.

Type of change

Please mark relevant options with an x in the brackets.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires documentation changes (link at least one user or developer documentation issue):
• Algorithm update - updates algorithm documentation/questions/answers etc.
• Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Integration tests
• Unit tests
• Manual tests
• No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

• Check if the code is well documented
• Check if the behavior is what is expected
• Check if the code is well tested
• Check if the code is readable and well formatted
• Additional checks (document below if any)
• Check if documentation update issue(s) are created if the option This change requires a documentation update above is selected

Screenshots (if appropriate):

Questions (if appropriate):

[msevestre]

@rwmcintosh Thoughts? Not fond of generating lots of specific exception, especially without parameters

[rwmcintosh]

@rwmcintosh Thoughts? Not fond of generating lots of specific exception, especially without parameters

Yeah, we looked at this one together and it's just that we'd be passing the building block and/or module and/or the string down into where the exception is thrown (it's a couple calls lower in the stack) just in case the parent container can't be found.

This way, we just throw this specific exception and catch it where the domain objects are being held so that we can create a meaningful message.

[msevestre]

Ok so no reason for me to make this exception public. Can it be declared internal , even with the file itself ? This should not be used anywhere else

Also is base() required ?

[rwmcintosh]

Yeah good idea. Nested class even.