Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2176 Data importer: error when "Reload under the same settings" #2251

Merged

Conversation

rwmcintosh
Copy link
Member

Fixes #2176

Description

A calculation is made to determine if data sets are equivalent or not, one of the checks is to make sure that all the metadata is the same. In the case from the issue the metadata are different in that there is additional metadata in the new import rather than just different values. That was not taken into account

Type of change

Please mark relevant options with an x in the brackets.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires documentation changes (link at least one user or developer documentation issue):
  • Algorithm update - updates algorithm documentation/questions/answers etc.
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Integration tests
  • Unit tests
  • Manual tests
  • No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

  • Check if the code is well documented
  • Check if the behavior is what is expected
  • Check if the code is well tested
  • Check if the code is readable and well formatted
  • Additional checks (document below if any)
  • Check if documentation update issue(s) are created if the option This change requires a documentation update above is selected

Screenshots (if appropriate):

Questions (if appropriate):

@rwmcintosh rwmcintosh requested review from msevestre and Yuri05 May 22, 2024 14:32
@rwmcintosh rwmcintosh self-assigned this May 22, 2024
@Yuri05 Yuri05 merged commit 74abdd4 into develop May 23, 2024
1 check passed
@Yuri05 Yuri05 deleted the 2176-data-importer-error-when-reload-under-the-same-settings branch May 23, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Verified
Development

Successfully merging this pull request may close these issues.

Data importer: error when "Reload under the same settings"
2 participants