Fixes #2161: #2162
Merged
Fixes #2161: #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
commented
Oct 28, 2023
| @@ -88,9 +88,9 @@ public TableFormula(IInterpolation interpolation) | |||
| UseDerivedValues = true; | |||
| } | |||
|
|
|||
| public virtual IEnumerable<ValuePoint> AllPoints() => _allPoints; | |||
| var tableFormula = comparison.Object1.DowncastTo<TableFormula>(); | ||
| return Captions.Comparisons.ValuePointAt(tableFormula.Name, formulaOwnerName, tableFormula.XDisplayValueFor(valuePoint.X)); | ||
| //We do not use enumerable comparison here as we need to compare the values by index | ||
| _enumerableComparer.CompareEnumerablesByIndex(comparison, x => x.AllPoints); |
There was a problem hiding this comment.
here we compare by index. That way comparison of tables with two points with very close x axis does not fail for no reason
|
Once this is merge, I'll update PK-Sim |
rwmcintosh
reviewed
Oct 30, 2023
| } | ||
|
|
||
| [Observation] | ||
| public void should_report_the_path_entries_and_different_entries_as_difference() |
There was a problem hiding this comment.
you mean should_not_report_the_path_entries_and_different_entries_as_difference right?
There was a problem hiding this comment.
the name is copied from the previous method which was also wrong.
rwmcintosh
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2161
Description
Comparision of tables should be done by trying to find matching points by axis. Instead, two tables are equal when all points in their order are the same. So we needed to introduce a comparison by index
Type of change
Please mark relevant options with an
xin the brackets.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Reviewer checklist
Mark everything that needs to be checked before merging the PR.
This change requires a documentation updateabove is selectedScreenshots (if appropriate):
Questions (if appropriate):