Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2151 Add distinction between PK-Sim and extension modules #2152

Merged

Conversation

rwmcintosh
Copy link
Member

@rwmcintosh rwmcintosh commented Oct 25, 2023

Fixes #2151

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please mark relevant options with an x in the brackets.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Algorithm update - updates algorithm documentation/questions/answers etc.
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Integration tests
  • Unit tests
  • Manual tests
  • No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

  • Check if the code is well documented
  • Check if the behavior is what is expected
  • Check if the code is well tested
  • Check if the code is readable and well formatted
  • Additional checks (document below if any)

Screenshots (if appropriate):

Questions (if appropriate):

@rwmcintosh rwmcintosh requested a review from msevestre October 25, 2023 12:45
@rwmcintosh rwmcintosh self-assigned this Oct 25, 2023
Copy link
Member

@msevestre msevestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the junk in the project file

@@ -43,6 +43,8 @@

<ItemGroup>
<None Remove="Icons.zip" />
<None Remove="Icons\PKSimModuleGreen.svg" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@rwmcintosh rwmcintosh merged commit ebc6f12 into develop Oct 25, 2023
@rwmcintosh rwmcintosh deleted the 2151-add-distinction-between-pk-sim-and-extension-modules branch October 25, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Verified
Development

Successfully merging this pull request may close these issues.

Add distinction between PK-Sim and extension modules
2 participants