Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2025 unhandled exception #2026

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Fixes #2025 unhandled exception #2026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OSPSuite.Core/Chart/CurveChart.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ public void RemoveCurvesForColumn(DataColumn dataColumn)
removeCurves(curve => curve.xData == dataColumn || curve.yData == dataColumn);
}

public void RemoveCurvesForColumns(IEnumerable<DataColumn> dataColumns) => dataColumns.Each(RemoveCurvesForColumn);
public void RemoveCurvesForColumns(IEnumerable<DataColumn> dataColumns) => dataColumns?.Each(RemoveCurvesForColumn);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the actual code change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heavy 😄


public void RemoveCurvesForDataRepository(DataRepository dataRepository) => RemoveCurvesForColumns(dataRepository);

Expand Down
10 changes: 9 additions & 1 deletion tests/OSPSuite.Core.Tests/Domain/CurveChartSpecs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
using OSPSuite.Core.Domain.Data;
using OSPSuite.Core.Domain.Services;
using OSPSuite.Core.Domain.UnitSystem;
using OSPSuite.Core.Extensions;
using OSPSuite.Helpers;

namespace OSPSuite.Core.Domain
Expand Down Expand Up @@ -287,4 +286,13 @@ public void should_also_update_title_and_description()
sut.Description.ShouldBeEqualTo(_other.Description);
}
}

public class When_removing_a_data_repository_from_a_chart_that_is_null : concern_for_CurveChart
{
[Observation]
public void should_not_crash()
{
sut.RemoveCurvesForDataRepository(null);
}
}
}
18 changes: 18 additions & 0 deletions ...s/OSPSuite.Presentation.Tests/Presentation/SimulationResidualVsTimeChartPresenterSpecs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using System.Collections.Generic;
using System.Linq;
using FakeItEasy;
using NPOI.HPSF;
using OSPSuite.BDDHelper;
using OSPSuite.BDDHelper.Extensions;
using OSPSuite.Core.Chart;
Expand Down Expand Up @@ -161,4 +162,21 @@ public void should_remove_the_zero_maker_curve_that_was_added_to_the_chart()
_residualVsTimeChart.Curves.Count.ShouldBeEqualTo(_residualResults.AllOutputResiduals.Count);
}
}

public class When_clearing_the_simulation_residual_vs_time_chart_presenter_that_was_initialized_without_observed_data : concern_for_SimulationResidualVsTimeChartPresenter
{
protected override void Context()
{
base.Context();
A.CallTo(() => _observedDataRepository.AllObservedDataUsedBy(A<ISimulation>._)).Returns(Enumerable.Empty<DataRepository>());

sut.InitializeAnalysis(_residualVsTimeChart, _simulation);
}

[Observation]
public void should_not_crash()
{
sut.Clear();
}
}
}