1860 unit test failing locally fixed #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuri05
approved these changes
Jan 6, 2023
rwmcintosh
reviewed
Jan 6, 2023
| @@ -50,7 +51,8 @@ protected override void LoadFromFile(string path) | |||
| while (csv.ReadNextRecord()) | |||
| { | |||
| csv.CopyCurrentRecordTo(currentRow); | |||
| var rowList = currentRow.Select(x => x.Replace(csvSeparators.DecimalSeparator, '.')).ToList(); | |||
| var currentCultureDecimalSeparator = Convert.ToChar(Thread.CurrentThread.CurrentCulture.NumberFormat.NumberDecimalSeparator); | |||
There was a problem hiding this comment.
This is pretty nice.
I pulled the branch and tried it on my PC and it works (using the starter project). However, it occurs to me that on my machine the new code is identical to what was there since my NumberDecimalSeparator will be '.' anyway.
Could you make sure that you can import this file from on your machine:
#1821
You could probably also skip the Replace if the characters searched and replaced are the same anyway (ie both '.' or both ',')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1860