Resetting sheet marks on reset format based on current sheet #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
reviewed
Mar 4, 2022
|
|
||
| public void ClearTabMarks() | ||
| { | ||
| SetTabMarks(new Cache<string, TabMarkInfo>(onMissingKey: _ => new TabMarkInfo(errorMessage: null, isLoaded: false))); |
There was a problem hiding this comment.
the info on how the cache is created is leaking here. Probably the presenter should be the one to call SetTabMarks with the right init (or just clear the cache that it has locally presumably),. This can be merged but this could be optimized a bIT
There was a problem hiding this comment.
I think you are right... It will be enough with setting the marks again from the presenter.
msevestre
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1503 (Resetting sheet marks on reset format based on current sheet)