-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of previously imported observed data from another data source #785
Comments
Before update is finally performed a confirmation dialog should be displayed, where the user sees, how many new datasets are added, how many old datasets are deleted, how many datasets are updated, how many old datasets remain identical. |
Doesn't the uses invisible datasource grouping bear the risk, that in any non trivial distribution of the datasets of a datasource to multiple folders the user does not oversee, what s/he is updating? I personally find it more clear to have a view where the datasets (= timeseries = curves) are grouped into imports (based on a import configuration and a data source), which could perhaps be done in a hierarchical view like in #786. But I admit, that the impact of such an update, e.g. update of plots is anyway somehow hidden to the user and requires a careful follow up in non trivial cases. So the users should reflect this feature carefully. |
The reload process currently has two options: reloading one specific dataset or reloading all the datasets that come from an excel file. The first option should not be available anymore - only reloading a whole file should be possible. To do this the reload process should not delete the old datasets as is being done currently, but should load all the datasets from the file again, then present the user with an overview of what is currently loaded, what will be overwritten and what will be loaded as a new dataset (because of changes/additions to the excel file). Afterwards the data in the datasets that are going to be overwritten have to be edited - that way the simulations using those datasets will not lose their references to them. |
Implemented as part of Importer Redesign |
When importing observed data sets, one import process results in (generally) N observed data sets imported into a project. N>=1 (based on the grouping information).
It should be possible to update observed data sets imported from one data source by selecting another data source.
Proposed workflow:
User selects ONE observed data set in a project and then "Update from new data source"
Software detects if there are other observed data sets in the project which were imported from the same data source. If YES: user is informed that further data sets will be updated.
User defines a new data source
Software checks if the new data source has the same structure (e.g. data columns used by the import configuration) as the original one. If NOT: ERROR (Update from the new data source not possible)
Software checks if the new data source has the same combinations of metadata relevant for grouping. If NOT:
Example:
observed data is imported from
which results in 2 data sets: Human|Brain|Plasma and Human|Liver Plasma

Use case 1
New data source contains the same grouping data (
Human|Brain|Plasma
andHuman|Liver Plasma
) e.g.In this case time and concentration of previosly imported data sets (
Human|Brain|Plasma
andHuman|Liver Plasma
) will be just updated with the new valuesUse case 2
Information about some previously available data sets is not available in the new data source, e.g.
Software checks if
Human|Liver|Plasma
is used in the project.Human|Brain|Plasma
will be updated with the new data andHuman|Liver|Plasma
will be deleted from the projectUse case 3
Information about all previously available data sets is available in the new data source; ADDITIONALY information about new data sets was added, e.g.
In this case time and concentration of previosly imported data sets (
Human|Brain|Plasma
andHuman|Liver Plasma
) will be updated with the new values AND the new data set forHuman|Heart|Plasma
will be added automaticallyPrevious state of the discussion
When importing observed data sets, one import process results in (generally) N observed data sets imported into a project. N>=1 (based on the grouping information).It should be possible to update observed data sets imported from one data source by selecting another data source.
Proposed workflow:
User selects ONE observed data set in a project and then "Update from new data source"
Software detects if there are other observed data sets in the project which were imported from the same data source. If YES: user is asked if ALL those data sets should be updated or only the selected one (to be discussed: do we need this step or should ALL datasets be updated automatically?)
User defines a new data source
Software checks if the new data source has the same structure (e.g. data columns used by the import configuration) as the original one. If NOT: ERROR (Update from the new data source not possible)
Software checks if the new data source has the same combinations of metadata relevant for grouping. If NOT: to be discussed. Following scenarios are possible
a) Option 1: ERROR (Update from the new data source not possible)
b) Option 2: Observed data sets not available in the new data source are removed from project (complicated if some of observed data sets are used in simulations/PIs, etc!)
c)Option 3: Data sets available in the new data source are updated with the new data. Data sets not available in the new data source are kept AS IS.
d)Option 4: User can select and choose between Error/Delete(?)/Keep (previous options)
Preview is shown (s. Preview of data in the import configuration editor #625)
Example:
observed data is imported from
which results in 2 data sets: Human|Brain|Plasma and Human|Liver Plasma

Use case 1
New data source contains the same grouping data (
Human|Brain|Plasma
andHuman|Liver Plasma
) e.g.In this case time and concentration of previosly imported data sets (
Human|Brain|Plasma
andHuman|Liver Plasma
) will be just updated with the new valuesUse case 2
Information about some previously available data sets is not available in the new data source, e.g.
If the user decided to update
Human|Brain|Plasma
ONLY - that's fine. However if the user decided to update ALL data sets (thusHuman|Brain|Plasma
andHuman|Liver|Plasma
), then it depends on how we want to proceedHuman|Brain|Plasma
will be updated with the new data andHuman|Liver|Plasma
will be deleted from the project (complicated if some of observed data sets are used in simulations/PIs, etc!)Human|Brain|Plasma
will be updated with the new data and Human|Liver|Plasma will be kept in the project AS ISUse case 3
Information about all previously available data sets is available in the new data source; ADDITIONALY information about new data sets was added, e.g.
In this case time and concentration of previosly imported data sets (
Human|Brain|Plasma
andHuman|Liver Plasma
) will be updated with the new values. If the new data set forHuman|Heart|Plasma
will be added automatically depends on the decision for the step 6 aboveThe text was updated successfully, but these errors were encountered: