Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of data ranges #624

Closed
Yuri05 opened this issue Oct 9, 2019 · 4 comments
Closed

Handling of data ranges #624

Yuri05 opened this issue Oct 9, 2019 · 4 comments
Labels
Importer Observed data importer RFC Request For Comments

Comments

@Yuri05
Copy link
Member

Yuri05 commented Oct 9, 2019

During creating of import configuration user can optionally select a data range to be used for import.
For the use case described in #785 (Update of existing observed data) and #622 (import of new datasets based on a given import configuration): relevant data range might grow or shrink in the new data source.
Proposal for the handling in case of update:

  • Import configuration saves top left cell of the selected data range
  • When a new data source is imported: data range is extended to the right and to the bottom until the right column / the bottom row are not empty
@Yuri05 Yuri05 added RFC Request For Comments Importer Observed data importer labels Oct 9, 2019
@msevestre
Copy link
Member

I somewhat disagree. Data amount would grow or shrink, but only if NO RANGE was selected correct?
If a range was selected (e.g. Col 1 to Col 10 and row 20 to row 30), then the range would not change

@Yuri05
Copy link
Member Author

Yuri05 commented Oct 9, 2019

If a range was selected (e.g. Col 1 to Col 10 and row 20 to row 30), then the range would not change

Regarding the columns: think you are right, range should not change.
Regarding the rows (after some thinking): it depends. There 2 use cases here:

  • user wants exactly the selected range (e.g. only rows 1 to 20). Then it should not increase.
  • user wants ALL the data, but the whole data block starts "somewehere". In this case it should increase.
    Maybe we will need an additional option to differentiate between those 2 scenarios.

@msevestre
Copy link
Member

In my opinion, the user should perform work on the source file before importing
I do not see how this use case make sense to select a SPECIFIC use range, and then ask the tool to magically extend it

I agree that if no range is selected, the data should extend with the number of rows

Does data extension by column make sense at all? I know it's possible to construct such case but do we really need this?

@Yuri05
Copy link
Member Author

Yuri05 commented Oct 9, 2019

Does data extension by column make sense at all? I know it's possible to construct such case but do we really need this?

I think indeed, we don't need this

@Yuri05 Yuri05 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Importer Observed data importer RFC Request For Comments
Projects
None yet
Development

No branches or pull requests

2 participants