Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run PI if it is not already open #2288

Closed
PavelBal opened this issue Jul 30, 2024 · 1 comment · Fixed by #2290
Closed

Cannot run PI if it is not already open #2288

PavelBal opened this issue Jul 30, 2024 · 1 comment · Fixed by #2290
Assignees

Comments

@PavelBal
Copy link
Member

  1. Open the "Midazolam" project from here https://github.com/Open-Systems-Pharmacology/OSP-PBPK-Model-Library/tree/master/Midazolam
  2. Try to open a parameter identification:

Application:
PK-Sim® 12.0.299

Exception has been thrown by the target of an invocation.

Object reference not set to an instance of an object.

Stack trace:

at OSPSuite.Core.Domain.SimulationQuantitySelection.setQuantity()
   at OSPSuite.Core.Domain.SimulationQuantitySelection.get_Quantity()
   at OSPSuite.Core.Domain.OutputMapping.get_Output()
   at OSPSuite.Core.Domain.OutputMapping.get_IsValid()
   at OSPSuite.Core.Domain.Services.ParameterIdentificationValidator.<>c.<Validate>b__2_3(OutputMapping x)
   at System.Linq.Enumerable.Any[TSource](IEnumerable`1 source, Func`2 predicate)
   at OSPSuite.Core.Domain.Services.ParameterIdentificationValidator.Validate(ParameterIdentification parameterIdentification)
   at OSPSuite.Core.Domain.Services.EntityValidator.Visit(ParameterIdentification parameterIdentification)
 --- End of inner exception stack trace ---
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)
   at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters)
   at OSPSuite.Utility.Visitor.VisitorInvoker.invokeVisitMethod[T](IVisitor visitor, T objectToVisit, MethodInfo method)
   at OSPSuite.Utility.Visitor.VisitorInvoker.InvokeVisit[T](IVisitor visitor, T objectToVisit)
   at OSPSuite.Utility.Visitor.VisitorExtensions.Visit[T](IVisitor visitor, T objectToVisit)
   at OSPSuite.Core.Domain.ObjectBase.AcceptVisitor(IVisitor visitor)
   at OSPSuite.Core.Domain.ParameterIdentifications.ParameterIdentification.AcceptVisitor(IVisitor visitor)
   at OSPSuite.Core.Domain.Services.EntityValidator.<validateEntities>b__5_0(IObjectBase entity)
   at OSPSuite.Utility.Extensions.EnumerableExtensions.Each[T](IEnumerable`1 list, Action`1 action)
   at OSPSuite.Core.Domain.Services.EntityValidator.validateEntities(IReadOnlyList`1 entities)
   at OSPSuite.Core.Domain.Services.EntityValidator.Validate(IObjectBase objectBase)
   at OSPSuite.Presentation.Services.EntityValidationTask.Validate(IObjectBase objectToValidate)
   at OSPSuite.Core.Domain.Services.ParameterIdentifications.ParameterIdentificationRunner.<Run>d__8.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at OSPSuite.Core.Extensions.ExceptionExtensions.<DoWithinExceptionHandler>d__6.MoveNext()
@benjaperez1983 benjaperez1983 transferred this issue from Open-Systems-Pharmacology/PK-Sim Aug 2, 2024
@benjaperez1983 benjaperez1983 self-assigned this Aug 2, 2024
benjaperez1983 added a commit that referenced this issue Aug 2, 2024
@rwmcintosh rwmcintosh changed the title Cannot open PI Cannot run PI if it is not already open Aug 2, 2024
@rwmcintosh
Copy link
Member

At the time of this bug report another bug meant that if you double clicked on a PI, the PI would run instead of open. @PavelBal thought the issue was related to opening the PI, but it's related to running a PI that is not already open (in PK-Sim).

Fixing this issue of running a not-open PI and then updating core will fix both issues

benjaperez1983 added a commit that referenced this issue Aug 8, 2024
rwmcintosh pushed a commit that referenced this issue Aug 13, 2024
* #2288 cannot open PI

* #2288 test and code cleanup
@github-project-automation github-project-automation bot moved this from In Progress to Fixed in v12 Aug 13, 2024
@Yuri05 Yuri05 moved this from Fixed to Verified in v12 Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Verified
Development

Successfully merging a pull request may close this issue.

4 participants