Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V12: PK-Analysis for multiple administration corrupted #2244

Closed
Yuri05 opened this issue Feb 23, 2024 · 1 comment · Fixed by #2245
Closed

V12: PK-Analysis for multiple administration corrupted #2244

Yuri05 opened this issue Feb 23, 2024 · 1 comment · Fixed by #2245
Milestone

Comments

@Yuri05
Copy link
Member

Yuri05 commented Feb 23, 2024

Undefined.zip
E.g. open the attached project snapshot (multiple IV) and go to the PK-Analysis:

In V11:

In V12:

@Yuri05 Yuri05 added this to the Version 12 milestone Feb 23, 2024
@rwmcintosh
Copy link
Member

This is because the simulation is created with applications under the Events container now. Within allApplicationsForMolecule only the Root is searched for EventGroups that contain applications.

Is it enough to look for applications both directly under Root as well as under Events?

And then combine them?

var applicationsFromEventContainer = getEventGroupsFrom(simulation.Model.Root.GetSingleChildByName<IContainer>(Constants.EVENTS));
var applicationEventGroupFromRoot = getEventGroupsFrom(simulation.Model.Root);

There are a bunch of ways to recurse the structure and get all the applications, I'm just not sure what approach is best for this.

@rwmcintosh rwmcintosh transferred this issue from Open-Systems-Pharmacology/PK-Sim May 10, 2024
msevestre pushed a commit that referenced this issue May 15, 2024
* Fixes #2244 PK-Analysis for multiple administration corrupted

* revise the strategy to find all applications
@github-project-automation github-project-automation bot moved this from Accepted to Fixed in v12 May 15, 2024
@Yuri05 Yuri05 moved this from Fixed to Verified in v12 Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Verified
2 participants